Change the tidy license checker #147843
Merged
Change the tidy license checker #147843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more permissive than Apache-2.0 which is already allowed.
With this the only remaining license exceptions are for licenses that are to copyleft to varying degrees.
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
rustbot
added
A-tidy
|
r? @clubby789 rustbot has assigned @clubby789. Use |
bjorn3
commented
Oct 18, 2025
src/tools/tidy/src/deps.rs
Outdated
| "Apache-2.0 OR MIT", | ||
| "Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT", // wasi license | ||
| "Apache-2.0 WITH LLVM-exception", | ||
| "Apache-2.0", |
There was a problem hiding this comment.
I'm surprised we allow bare Apache-2.0 for the runtime. This was added in a dependency update PR over a year ago.
There was a problem hiding this comment.
Likewise; I'd like to know where this is used, and if we could avoid it.
There was a problem hiding this comment.
Looks like it isn't used for the runtime, only for tools. I've pushed a commit to move all licenses that are not like MIT to the tools-only license list.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 20, 2025
Rollup of 4 pull requests Successful merges: - #147577 (Improve error message for ambiguous numeric types in closure parameters) - #147785 (fix incorrect line number when building trimmed multi-line suggestions) - #147814 (btree: some cleanup with less unsafe) - #147843 (Change the tidy license checker) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 20, 2025
Rollup merge of #147843 - bjorn3:tidy_licenses, r=clubby789 Change the tidy license checker This adds a bunch of licenses to the global list of allowed licenses that are at least as permissive as some other license in the list. In addition it adds another list for licenses that are allowed to be used by tools, but not by the runtime. All permissive licenses from the exception lists are added here. This makes it clearer what actual exceptions to our permissive licensing policy are and will hopefully make it a bit easier to review future changes to the list of licenses rather than just adding whatever license is necessary to the global list of allowed licenses or to the list of exceptions.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Oct 20, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#147577 (Improve error message for ambiguous numeric types in closure parameters) - rust-lang/rust#147785 (fix incorrect line number when building trimmed multi-line suggestions) - rust-lang/rust#147814 (btree: some cleanup with less unsafe) - rust-lang/rust#147843 (Change the tidy license checker) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bunch of licenses to the global list of allowed licenses that are at least as permissive as some other license in the list. In addition it adds another list for licenses that are allowed to be used by tools, but not by the runtime. All permissive licenses from the exception lists are added here. This makes it clearer what actual exceptions to our permissive licensing policy are and will hopefully make it a bit easier to review future changes to the list of licenses rather than just adding whatever license is necessary to the global list of allowed licenses or to the list of exceptions.